Fix #10024: chown/chgrp exit code with multiple files #10034
Closed
+64
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Some jobs are failing |
Merging this PR will not alter performance
Comparing 
Footnotes
|
sylvestre
reviewed
Jan 4, 2026
tests/by-util/test_chgrp.rs
Outdated
| } | ||
|
|
||
| #[test] | ||
| #[cfg(not(target_vendor = "apple"))] |
|
GNU testsuite comparison: |
added 5 commits
January 4, 2026 10:50
Use |= instead of = to accumulate errors when processing multiple files. Previously, if the last file succeeded, the exit code would be 0 even if earlier files failed. Added tests to verify correct exit code behavior.
The test test_chgrp_multiple_files_error_on_first_success_on_last is disabled on apple scenario. Clean up unnecessary comment.
Test reenabled for apple scenario by using getegid().
Use at_and_ucmd! macro instead TestScenario.
Collaborator
|
This issue was already addressed by: #10035 |
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use |= instead of = to accumulate errors when processing multiple files. Previously, if the last file succeeded, the exit code would be 0 even if earlier files failed.
Added tests to verify correct exit code behavior.