Fix panic in who > /dev/full #10801
Open
Fix panic in who > /dev/full #10801
+41
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
This comment was marked as resolved.
This comment was marked as resolved.
|
GNU testsuite comparison: |
Contributor
|
some jobs are failing |
|
GNU testsuite comparison: |
Author
|
@sylvestre, @oech3, now CI is passing. Should I add test with |
sylvestre
reviewed
Feb 10, 2026
| use std::borrow::Cow; | ||
| use std::ffi::CStr; | ||
| use std::fmt::Write; | ||
| use std::io::{self, Write as _}; |
Contributor
There was a problem hiding this comment.
please remove the "as _"
Author
There was a problem hiding this comment.
Then it would conflict with use std::fmt::Write;:
error[E0252]: the name `Write` is defined multiple times
--> src/uu/who/src/platform/unix.rs:21:21
|
20 | use std::fmt::Write;
| --------------- previous import of the trait `Write` here
21 | use std::io::{self, Write};
| ^^^^^ `Write` reimported here
|
Contributor
There was a problem hiding this comment.
ok, just remove the declaration then ?!
Contributor
There was a problem hiding this comment.
No. needed for std{out,err}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10550