Skip to content

Conversation

@brody2002
Copy link
Collaborator

@brody2002 brody2002 commented Jan 30, 2026

Fix:

Switching between the InteractiveDismissDisabledKey can result in the view's offset being off from the center and stuck there.

@brody2002 brody2002 requested a review from zac January 30, 2026 20:31
@brody2002 brody2002 closed this Jan 30, 2026
@brody2002 brody2002 reopened this Jan 30, 2026
@brody2002 brody2002 force-pushed the feature/parameter-landscape-dismiss branch from bff6a10 to b0966d5 Compare January 30, 2026 23:26
@brody2002 brody2002 changed the title Parameter: Prevent Dismiss Landscape InteractiveDismissDisabledKey Rotation Bug Jan 30, 2026
Copy link
Member

@zac zac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question 👍

didSet {
panGestureRecognizer.isEnabled = isEnabled
edgeGestureRecognizer.isEnabled = isEnabled
panGestureRecognizer.isEnabled = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👆 If we aren't modifying these, should they even be set here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zac It's no longer needed! Good catch

@brody2002 brody2002 merged commit 1a392ca into main Feb 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants