Skip to content

Conversation

@r-ricci
Copy link
Contributor

@r-ricci r-ricci commented Jan 10, 2026

Testing the changes

  • I tested the changes in this PR: briefly

@dkwo
Copy link
Contributor

dkwo commented Jan 11, 2026

In my experiments, I noticed that if you add configure_args+=" --ninja" to nodejs, then it uses all cores to build, instead of single core.

@dkwo
Copy link
Contributor

dkwo commented Jan 11, 2026

Also, copying from ci for reference:

2026-01-10T17:14:22.4743309Z Failed tests:
2026-01-10T17:14:22.4743933Z out/Release/node /builddir/nodejs-24.12.0/test/parallel/test-datetime-change-notify.js
2026-01-10T17:14:22.4744926Z out/Release/node /builddir/nodejs-24.12.0/test/parallel/test-http2-client-unescaped-path.js
2026-01-10T17:14:22.4745964Z out/Release/node /builddir/nodejs-24.12.0/test/parallel/test-http2-multi-content-length.js
2026-01-10T17:14:22.4746955Z out/Release/node /builddir/nodejs-24.12.0/test/parallel/test-http2-reset-flood.js
2026-01-10T17:14:22.4748080Z out/Release/node /builddir/nodejs-24.12.0/test/parallel/test-http2-max-invalid-frames.js
2026-01-10T17:14:22.4749083Z out/Release/node /builddir/nodejs-24.12.0/test/parallel/test-http2-misbehaving-flow-control.js
2026-01-10T17:14:22.4750196Z out/Release/node /builddir/nodejs-24.12.0/test/parallel/test-http2-misbehaving-flow-control-paused.js
2026-01-10T17:14:22.4751153Z out/Release/node /builddir/nodejs-24.12.0/test/parallel/test-icu-env.js
2026-01-10T17:14:22.4752677Z out/Release/node --experimental-sqlite --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout /builddir/nodejs-24.12.0/test/parallel/test-sqlite-session.js
2026-01-10T17:14:22.4754123Z out/Release/node /builddir/nodejs-24.12.0/test/wpt/test-url.js
2026-01-10T17:14:22.4754821Z out/Release/node /builddir/nodejs-24.12.0/test/wpt/test-urlpattern.js

@r-ricci
Copy link
Contributor Author

r-ricci commented Jan 11, 2026 via email

@dkwo
Copy link
Contributor

dkwo commented Jan 12, 2026

But does it actually do that for you? Last time I checked, this specific package did not do it for me. (I know this is the case in general, with the default being 4.)

@r-ricci
Copy link
Contributor Author

r-ricci commented Jan 12, 2026

But does it actually do that for you? Last time I checked, this specific package did not do it for me.

It works for me, at least with this version of nodejs. I didn't test earlier versions.

(I know this is the case in general, with the default being 4.)

# [OPTIONAL]
# Number of parallel jobs to execute when building packages that
# use make(1) or alike commands. Defaults to the result of nproc(1).
# If nproc(1) is not available, defaults to 1.
#
#XBPS_MAKEJOBS=4

@dkwo
Copy link
Contributor

dkwo commented Jan 13, 2026

You are right, they fixed it in this version. Sorry for the noise.

@dkwo
Copy link
Contributor

dkwo commented Jan 17, 2026

see 6db8b83

@r-ricci r-ricci closed this Jan 17, 2026
@r-ricci r-ricci deleted the nodejs branch January 17, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants