fix(tracer): agent on vefaas lost tracer callback

[zakahan]

No description provided.

[Copilot]

Pull Request Overview

This PR fixes an issue where agent tracers were not properly initialized in the VeFaaS environment by ensuring tracer callbacks are updated after extending the tracers list.

• Extracts tracer callback setup logic into a reusable update_tracers_callback() method
• Adds deduplication logic to prevent duplicate callback registration
• Calls the new method after extending tracers in the VeFaaS template to ensure proper initialization

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
veadk/cli/services/vefaas/template/src/app.py	Calls update_tracers_callback() after extending agent tracers
veadk/agent.py	Refactors tracer callback setup into a reusable method with deduplication

[Copilot]

Using not in for list membership checking has O(n) complexity. Consider using a set to track added callbacks for O(1) lookups, especially if the number of tracers could be large.

Suggested change

	for tracer in self.tracers:
	# Add tracer callbacks if not already added
	if tracer.llm_metrics_hook not in self.before_model_callback:
	self.before_model_callback.append(tracer.llm_metrics_hook)
	if tracer.token_metrics_hook not in self.after_model_callback:
	self.after_model_callback.append(tracer.token_metrics_hook)
	before_set = set(self.before_model_callback)
	after_set = set(self.after_model_callback)
	for tracer in self.tracers:
	# Add tracer callbacks if not already added
	if tracer.llm_metrics_hook not in before_set:
	self.before_model_callback.append(tracer.llm_metrics_hook)
	before_set.add(tracer.llm_metrics_hook)
	if tracer.token_metrics_hook not in after_set:
	self.after_model_callback.append(tracer.token_metrics_hook)
	after_set.add(tracer.token_metrics_hook)

[Copilot]

Using not in for list membership checking has O(n) complexity. Consider using a set to track added callbacks for O(1) lookups, especially if the number of tracers could be large.

Suggested change

	for tracer in self.tracers:
	# Add tracer callbacks if not already added
	if tracer.llm_metrics_hook not in self.before_model_callback:
	self.before_model_callback.append(tracer.llm_metrics_hook)
	if tracer.token_metrics_hook not in self.after_model_callback:
	self.after_model_callback.append(tracer.token_metrics_hook)
	before_set = set(self.before_model_callback)
	after_set = set(self.after_model_callback)
	for tracer in self.tracers:
	# Add tracer callbacks if not already added
	if tracer.llm_metrics_hook not in before_set:
	self.before_model_callback.append(tracer.llm_metrics_hook)
	before_set.add(tracer.llm_metrics_hook)
	if tracer.token_metrics_hook not in after_set:
	self.after_model_callback.append(tracer.token_metrics_hook)
	after_set.add(tracer.token_metrics_hook)

[cuericlee]

/lgtm