fix: Avoid modifying original config in AgentBuilder._build() #509
+8
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes #508
Problem
Currently, the
AgentBuilder._build()method usespop()operations which modify the original config dict, potentially causing:pop()is not clear enoughUse dictionary comprehension to create a new dict, filtering out fields that need to be passed explicitly:
Changes:
Remove agent_config.pop("sub_agents")
Remove agent_config.pop("tools")
Add dictionary filtering to create config_for_init
Add comments explaining the change
Benefits
No side effects: doesn't modify original config
Reusable: config can be used multiple times
Clear intent: code purpose is explicit
Best practice: follows immutability principle