Files, Groups, Props, Users, NotificationV2

[VinyarionHyarmendacil]

Files:

• Add GET /agreement
• Add POST /agreement
• Add PUT /assetReview/{assetReviewId}/notes
• Add PUT /files/order
  Groups:
• Update DELETE /groups/{groupId}
  • Add missing optional query parameter
• Update POST /groups/{groupId}/join
  • Add missing optional query parameter
  • Add missing optional request body
• Add GET /groups/{groupId}/auditLogTypes
• Add POST /groups/{groupId}/block
• Add PUT /groups/{groupId}/invites
• Add GET /groups/{groupId}/members/search
• Add GET /groups/{groupId}/transfer
• Add POST /groups/{groupId}/transfer
• Add DELETE /groups/{groupId}/transfer
  Props:
• Add GET /props
• Add POST /props
• Add PUT /props/{propId}
• Add DELETE /props/{propId}
• Add GET /props/{propId}/publish
• Add PUT /props/{propId}/publish
• Add DELETE /props/{propId}/publish
  Users:
• Add GET /users/{userId}/groups/invited
• Add GET /users/{userId}/groups/permissions
• Add GET /users/{userId}/groups/userblocked
• Add DELETE /users/{userId}/persist
  NotificationV2:
• Update NotificationV2Type to add group.transfer
• Update NotificationV2 to add data types
• Add NotificationV2DataGroupInformative
• Add NotificationV2DataGroupTransfer

[VinyarionHyarmendacil]

Unless I am utterly blind, the three linting errors for groups.yaml Parameter "groupRoleId" must be used in path "/groups/{groupId}/transfer". and 2xEvery operation must have unique "operationId". seem to actually be incorrect, no?

[jellejurre]

yeah, looked at the lint issue and I'm not sure what's happening either. Maybe some sort of weird indentation issue?

[jellejurre]

Fixed lint issue

[jellejurre]

How would one obtain an asset review ID? it seems there is only one endpoint for it

[jellejurre]

Maybe move galleryorder to group tag, even though it's a /files endpoint

[jellejurre]

Also what does the gallery image order endpoint actually do? it doesnt seem to change the order

[VinyarionHyarmendacil]

How would one obtain an asset review ID? it seems there is only one endpoint for it

From what I can tell, you have to submit an avatar to be sold in a group's store with POST /assetReviews/avatarProduct { "avatarId": <AvatarID>, "reviewNotes": <string> } -> ? and then the avatar will have the activeAssetReviewId property on it until it gets accepted (idk how that works yet). I originally thought AssetReviews were related to content moderation, but I think it seems to be more of a submit/approve-content-for-group-store-page thing, thereby actually being more of a Creator Economy endpoint

Maybe move galleryorder to group tag, even though it's a /files endpoint

Eh, I hadn't originally put it in that category because the endpoint path looked like it belonged with the other generic file endpoints and because I initially suspected it could reorder the user's gallery image order, but it ended up not being able to afaik

Also what does the gallery image order endpoint actually do? it doesnt seem to change the order

Yeah, I suspect it's something that either isn't fully implemented or was dropped and forgotten, but the endpoint is still reachable so oh well

think everything was handled