Skip to content

Conversation

@aberlioz
Copy link

@aberlioz aberlioz commented Oct 25, 2024

The pin on version ^5.12.0 of package importlib-resources was introduced in this PR: #60

It prevents applications running on higher versions of python to install the newest importlib-resources versions.

Considering the usage of the lib, one can argue that we don't even need this dependencies for python version 3.9 and above.

References

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@aberlioz
Copy link
Author

Hello @oleg-nenashev 👋🏻 ,
Do you know if someone can please have a look at this 🙏🏻 ?
It should be a very straightforward change.

@oleg-nenashev
Copy link
Member

Cc @leeturner

@leeturner
Copy link
Contributor

Fixed in - #120

@leeturner leeturner closed this Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants