Skip to content

Minor build fixes#684

Merged
douzzer merged 1 commit intowolfSSL:masterfrom
danielinux:minor_build_fixes
Feb 11, 2026
Merged

Minor build fixes#684
douzzer merged 1 commit intowolfSSL:masterfrom
danielinux:minor_build_fixes

Conversation

@danielinux
Copy link
Member

  • exclude attestation symbols for non-PSA builds
  • fix dependency of signed test-application on keytools

Copilot AI review requested due to automatic review settings February 11, 2026 18:30
- exclude attestation symbols for non-PSA builds
- fix dependency of signed test-application on keytools
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to resolve build-time issues by (1) preventing attestation/UDS code from being compiled into non-PSA builds for STM32 L5/H5 targets, and (2) fixing a missing build dependency so the signed test-application can be produced reliably.

Changes:

  • Guard STM32L5/STM32H5 UDS derivation and related hash includes behind WOLFCRYPT_TZ_PSA.
  • Fix STM32H5 SHA3-384 hashing support by including the correct wolfCrypt header and using the correct hash/digest types.
  • Make test-app/image_v1_signed.bin depend on keytools_check so signing doesn’t start before key tools are built.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
hal/stm32l5.c Wrap UDS/key-derivation logic (and hash includes) with WOLFCRYPT_TZ_PSA to avoid pulling it into non-PSA builds.
hal/stm32h5.c Same PSA-guarding as STM32L5; also fixes SHA3-384 header/type usage for UID-derived UDS hashing.
Makefile Adds keytools_check dependency to the signed test-app image build rule.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@douzzer douzzer merged commit 7b871c6 into wolfSSL:master Feb 11, 2026
508 of 512 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants