Conversation
Member
danielinux
commented
Feb 11, 2026
- exclude attestation symbols for non-PSA builds
- fix dependency of signed test-application on keytools
- exclude attestation symbols for non-PSA builds - fix dependency of signed test-application on keytools
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to resolve build-time issues by (1) preventing attestation/UDS code from being compiled into non-PSA builds for STM32 L5/H5 targets, and (2) fixing a missing build dependency so the signed test-application can be produced reliably.
Changes:
- Guard STM32L5/STM32H5 UDS derivation and related hash includes behind
WOLFCRYPT_TZ_PSA. - Fix STM32H5 SHA3-384 hashing support by including the correct wolfCrypt header and using the correct hash/digest types.
- Make
test-app/image_v1_signed.bindepend onkeytools_checkso signing doesn’t start before key tools are built.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
hal/stm32l5.c |
Wrap UDS/key-derivation logic (and hash includes) with WOLFCRYPT_TZ_PSA to avoid pulling it into non-PSA builds. |
hal/stm32h5.c |
Same PSA-guarding as STM32L5; also fixes SHA3-384 header/type usage for UID-derived UDS hashing. |
Makefile |
Adds keytools_check dependency to the signed test-app image build rule. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
douzzer
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.