-
Notifications
You must be signed in to change notification settings - Fork 99
remove keyboard auth callback and use generic auth callback #807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the keyboard interactive authentication callback functions and integrates keyboard auth into the generic user authentication callback.
- Removed deprecated keyboard auth callback declarations and functions.
- Introduced a new auth type macro (WOLFSSH_USERAUTH_KEYBOARD_SETUP) and updated logic across internal and example files to use the generic auth callback instead.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| wolfssh/ssh.h | Removed keyboard auth callback declarations and added new macro. |
| wolfssh/internal.h | Removed keyboard auth callback member from the context struct. |
| src/ssh.c | Removed keyboard-specific functions; updated keyboard auth request to use generic callback. |
| src/internal.c | Updated keyboard auth request handling to use userAuthCb and modified auth type usage. |
| examples/echoserver/echoserver.c | Adjusted example usage accordingly by removing calls to deprecated functions. |
Comments suppressed due to low confidence (1)
src/ssh.c:13379
- There is a mismatch between the authData type being set (WOLFSSH_USERAUTH_KEYBOARD) and the callback parameter (WOLFSSH_USERAUTH_KEYBOARD_SETUP) passed to userAuthCb. Consider aligning these values for consistent behavior.
authData->type = WOLFSSH_USERAUTH_KEYBOARD;
dfb418e to
d9f8480
Compare
62eafad to
59ed1ba
Compare
59ed1ba to
8a8ee95
Compare
ejohnstown
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZD19766
Note that this brakes backwards compatibility with the keyboard auth callbacks. Moving it over to use the generic auth callback framework.