Skip to content

Conversation

@ejohnstown
Copy link
Contributor

  1. Remove the macro definition and checks for the value "NO_BREAK".
  2. Use the wolfCrypt defined macro FALL_THROUGH instead of NO_BREAK.

1. Remove the macro definition and checks for the value "NO_BREAK".
2. Use the wolfCrypt defined macro FALL_THROUGH instead of NO_BREAK.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the custom NO_BREAK fall-through macro and updates all switch statements to use the FALL_THROUGH macro defined by wolfCrypt.

  • Drop NO_BREAK definition from wolfssh/port.h
  • Replace all NO_BREAK; usages with FALL_THROUGH; in SFTP, SCP, SSH, and internal code

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
wolfssh/port.h Remove legacy NO_BREAK macro definitions
src/wolfsftp.c Swap NO_BREAK for FALL_THROUGH in SFTP flows
src/wolfscp.c Swap NO_BREAK for FALL_THROUGH in SCP flows
src/ssh.c Swap NO_BREAK for FALL_THROUGH in SSH states
src/internal.c Swap NO_BREAK for FALL_THROUGH in internal flows
Comments suppressed due to low confidence (2)

wolfssh/port.h:1508

  • [nitpick] Consider adding a brief comment noting that NO_BREAK was removed in favor of the upstream FALL_THROUGH macro, so future maintainers understand why the old definitions are gone.
#ifndef WOLFSSH_UNUSED

wolfssh/port.h:1508

  • [nitpick] Ensure that FALL_THROUGH is always defined in this translation unit (e.g. provide a no-op fallback) or include the header where it’s defined, to prevent build errors on compilers without the attribute.
#ifndef WOLFSSH_UNUSED

@JacobBarthelmeh JacobBarthelmeh merged commit dd377d6 into wolfSSL:master Jul 10, 2025
93 checks passed
@ejohnstown ejohnstown deleted the fallthrough branch July 10, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants