Fixing a batch of issues reported by Coverity #817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejohnstown
force-pushed
the
cov
branch
3 times, most recently
from
db9a80d to
fc68795
Compare
1. Modify AssertNotNull() to use the same pattern as AssertNull(). The macro assigns the pointer to a local variable and that is checked. Fixes CIDs: 537020 573008 573010 573011 573013 573014 573015 573016 573017 573018 573022 573023 573024
1. Fix some resource leaks during error conditions where a socket or a file descriptor doesn't get closed in all error cases. 2. In wolfSSH_SFTP_RecvOpen(), initialize the file descriptor. 3. For 572902, the error case resource leaks are fixed. There's still an issue to resolve for storing the FD for use later. Fixes CIDs: 572856 572902* 573012 573019 573021 573076
JacobBarthelmeh
previously approved these changes
Jul 11, 2025
1. Remove the default password from the wolfSSH client app main function. It isn't set to anything. (It was originally an example client option.) 2. Remove handling the default password from the wolfSSH client app's user authentication callback. 3. Set the password size directly. 4. Changed a void typecast to WOLFSSH_UNUSED. Fixes CID: 572898
JacobBarthelmeh
approved these changes
Jul 11, 2025
douzzer
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*: Most of the issue is fixed. One part still needs fixing.