Bumping to Angular v11 & removing duplicate interfaces#48
Open
s4m0r4m4 wants to merge 3 commits intowordpress-clients:developfrom
Open
Bumping to Angular v11 & removing duplicate interfaces#48s4m0r4m4 wants to merge 3 commits intowordpress-clients:developfrom
s4m0r4m4 wants to merge 3 commits intowordpress-clients:developfrom
Conversation
Http --> HttpClient; Placeholder for RequestOptionsArgs; Cleaning up duplicate interfaces interspersed throughout files (Typescript bug was resolved);
This was referenced Jan 9, 2021
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I bumped dependencies to Angular v11
I also could not figure out why there were duplicate interfaces defined everywhere (like IWpApiComments for instance), so I consolidated them;