Conversation
--dry-run was defined on BaseCommand but only implemented by the synchronize command. All other commands would throw "Dry run not yet supported." at runtime. Move the option to SynchronizeCommand and remove the dry-run plumbing from Pgslice. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
stefanmb
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--dry-runwas defined as a global option onBaseCommand, but only thesynchronizecommand implemented it. All other commands would throw"Dry run not yet supported."at runtime.--dry-runfromBaseCommandtoSynchronizeCommandand removed the dry-run plumbing fromPgslice.Test plan
npm run buildpassesnpm test -- run)npx pgslice synchronize --helpshows--dry-runnpx pgslice prep --help) do not show--dry-run🤖 Generated with Claude Code