Adding in Authorization Access Evaluation endpoint #1473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@greptile review this pr plz |
Contributor
Greptile OverviewGreptile SummaryThis PR implements the Key Changes:
Issue Found:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Client
participant SDK as WorkOS SDK
participant Serializer
participant API as WorkOS API
Client->>SDK: check(options)
SDK->>Serializer: serializeAuthorizationCheckOptions(options)
Note over Serializer: Convert camelCase to snake_case<br/>Include only provided resource fields
Serializer-->>SDK: serialized payload
SDK->>API: POST /authorization/organization_memberships/{om_id}/check
API-->>SDK: { authorized: boolean }
SDK-->>Client: AuthorizationCheckResult
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
962
to
993
| describe('check', () => { | ||
| it('returns authorized when permission is granted (by resource ID)', async () => { | ||
| fetchOnce({ authorized: true }, { status: 200 }); | ||
|
|
||
| const result = await workos.authorization.check({ | ||
| organizationMembershipId: testOrgMembershipId, | ||
| permissionSlug: 'documents:edit', | ||
| resourceId: testResourceId, | ||
| }); | ||
|
|
||
| expect(fetchURL()).toContain( | ||
| `/authorization/organization_memberships/${testOrgMembershipId}/check`, | ||
| ); | ||
| expect(fetchBody()).toEqual({ | ||
| permission_slug: 'documents:edit', | ||
| resource_id: testResourceId, | ||
| }); | ||
| expect(result).toEqual({ authorized: true }); | ||
| }); | ||
|
|
||
| it('returns unauthorized when permission is not granted', async () => { | ||
| fetchOnce({ authorized: false }, { status: 200 }); | ||
|
|
||
| const result = await workos.authorization.check({ | ||
| organizationMembershipId: testOrgMembershipId, | ||
| permissionSlug: 'documents:delete', | ||
| resourceId: testResourceId, | ||
| }); | ||
|
|
||
| expect(result).toEqual({ authorized: false }); | ||
| }); | ||
| }); |
Contributor
There was a problem hiding this comment.
Consider adding test cases for resourceExternalId + resourceTypeSlug and resourceTypeSlug alone to validate all resource identification methods
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Contributor
Author
There was a problem hiding this comment.
added in
swaroopAkkineniWorkos
changed the title
swaroopAkkineniWorkos
changed the title
swaroopAkkineniWorkos
requested review from
alisherry,
atainter,
csrbarber and
mattgd
and removed request for
a team
| export * from './authorization-resource.serializer'; | ||
| export * from './create-authorization-resource-options.serializer'; | ||
| export * from './update-authorization-resource-options.serializer'; | ||
| export * from './authorization-check-options.serializer'; |
Contributor
There was a problem hiding this comment.
Missing semicolon (all other exports have semicolons)
Suggested change
| export * from './authorization-check-options.serializer'; | |
| export * from './authorization-check-options.serializer'; |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
csrbarber
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linear: https://linear.app/workos/issue/ENT-4372/sdk-updates
I decided to break up the work for ENT-4372 into a smaller pr's that we can be easily reviewed and merge them into ENT-4372-base-authorization-branch. Then we can have one final merge that merges ENT-4372-base-authorization-branch into the main.
desc: the goal of this pr is to implement the following endpoints in the node sdk.
check() | POST /authorization/organization_memberships/{om_id}/check
check() ~ https://github.com/workos/workos/blob/44963176350da59515a31bfeb5f5355b153d18e9/packages/api/src/authorization/authorization.controller.ts#L94