fix: use simple v-prefixed tags and fix gem publish path#441
Conversation
Release Please was creating tags like `workos/v6.1.0` instead of `v6.1.0` because `include-component-in-tag` defaults to true. This caused the publish workflow to look for `pkg/workos-workos/v6.1.0.gem` instead of `pkg/workos-6.1.0.gem`. - Set `include-component-in-tag: false` in release-please-config.json - Update VERSION extraction in release.yml to handle both tag formats Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Greptile OverviewGreptile SummaryThis PR updates release automation so release-please generates simple The intent is to prevent gem publishing failures when tags are component-prefixed (e.g. Confidence Score: 2/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant GitHub as GitHub Releases
participant Workflow as .github/workflows/release.yml
participant Rake as rake build
participant RubyGems as RubyGems
GitHub->>Workflow: release.published (GITHUB_REF_NAME = tag)
Workflow->>Workflow: VERSION = parse(GITHUB_REF_NAME)
Workflow->>Rake: bundle exec rake build
Rake-->>Workflow: pkg/workos-<version>.gem
Workflow->>RubyGems: gem push pkg/workos-${VERSION}.gem
RubyGems-->>Workflow: success/failure
|
| VERSION="${GITHUB_REF_NAME##*/v}" | ||
| bundle exec rake build | ||
| gem push pkg/workos-${VERSION}.gem --host https://rubygems.org |
There was a problem hiding this comment.
VERSION parsing breaks v-tags
VERSION="${GITHUB_REF_NAME##*/v}" only strips the prefix when the ref name contains a path segment ending in /v (e.g. workos/v6.1.0). For the intended new tag format v6.1.0, this leaves VERSION as v6.1.0, so the workflow will try to gem push pkg/workos-v6.1.0.gem (which won’t exist if the built gem is pkg/workos-6.1.0.gem). To support both formats, VERSION needs to normalize both vX.Y.Z and */vX.Y.Z to X.Y.Z.
Summary
include-component-in-tag: falseinrelease-please-config.jsonso future tags arev6.1.0instead ofworkos/v6.1.0release.ymlto handle both tag formats as a safety netContext
The v6.1.0 release (publish run) failed because:
workos/v6.1.0(component-prefixed)VERSIONvia${GITHUB_REF_NAME#v}→workos/v6.1.0(no leadingvto strip)gem pushlooked forpkg/workos-workos/v6.1.0.gemwhich doesn't existTest plan
v6.1.0🤖 Generated with Claude Code