fix(core): 🐛 fix style related to coreRequestProgressBar #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix style related to coreRequestProgressBar Ref #437
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes styling issues for the CoreRequestProgressBar component by updating its usage in layout components and adjusting its internals to accept external style classes.
- Updated AppContainerLayout and AppBuilderContainerLayout to pass explicit styleClasses to CoreRequestProgressBar.
- Modified CoreRequestProgressBar to sanitize incoming props and spread them onto its container.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package/components/layouts/_system/AppContainerLayout.js | Passes explicit styleClasses to CoreRequestProgressBar |
| package/components/layouts/_system/AppBuilderContainerLayout.js | Updates CoreRequestProgressBar invocation with styleClasses |
| package/components/feedback/CoreRequestProgressBar.js | Refactors to accept sanitized props and spread them to CoreBox |
| import { sanitizeComponentProps } from "../../utils/componentUtil"; | ||
| import CoreBox from "../layouts/CoreBox"; | ||
| export default function CoreRequestProgressBar() { | ||
| export default function CoreRequestProgressBar(props) { |
There was a problem hiding this comment.
Consider defining default prop values for styleClasses (for example, using defaultProps or default parameters) to ensure consistent styling when the component is used without explicitly passing styleClasses.
Suggested change
| export default function CoreRequestProgressBar(props) { | |
| export default function CoreRequestProgressBar(props = { styleClasses: [] }) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed style related to core RequestProgressBar
Ref #437
Related Issues
<!-List any related issues that this pull request addresses. -->
Testing
I have tested it in my local system, it works as expected.
Checklist
Screenshots (if applicable)
Additional Notes
Reviewers
Maintainer Notes