Skip to content

Conversation

@krystian-panek-vmltech
Copy link
Collaborator

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances Playwright end-to-end tests with screenshot capabilities and refactors test configuration. The changes centralize environment configuration, add a helper function for attaching screenshots to test reports, and restructure some test files for better organization.

Key changes:

  • Added screenshot attachment utility and integrated it across test files
  • Centralized configuration (BASE_URL, credentials, headers) in env.ts utility
  • Reorganized history tests by splitting them into separate automatic and general test files
  • Enhanced Java logging in ScriptScheduler for better debugging of boot script queueing

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
test/e2e/utils/page.ts New utility for attaching screenshots to test reports
test/e2e/utils/env.ts New centralized environment configuration with constants and header helpers
test/e2e/utils/context.ts Refactored to use centralized BASE_URL and authHeader constants
test/e2e/playwright.config.ts Updated to use centralized configuration and changed screenshot mode
test/e2e/001-general.spec.ts Added screenshots and new test for resetting tool state
test/e2e/002-console.spec.ts Added screenshots and improved tab selection assertion
test/e2e/003-tool-access.spec.ts Added screenshots and improved tab selection assertion
test/e2e/004-history.spec.ts Deleted - tests moved to other files
test/e2e/004-automatic-scripts.spec.ts New file for automatic script history tests
test/e2e/005-manual-scripts.spec.ts Added screenshots and removed standalone screenshot call
core/src/main/java/dev/vml/es/acm/core/script/ScriptScheduler.java Enhanced logging messages and added bootedScripts.clear() on demand boot
Taskfile.yml Added new tasks for test code generation and report viewing
Comments suppressed due to low confidence (1)

test/e2e/004-automatic-scripts.spec.ts:2

  • Unused import readFromCodeEditor.
import { readFromCodeEditor } from './utils/editor';

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@krystian-panek-vmltech krystian-panek-vmltech merged commit 1311cab into main Nov 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants