Merged
Conversation
martinfleis
reviewed
Nov 20, 2025
| @@ -956,6 +956,8 @@ def to_geodataframe( | |||
| return df.set_geometry(geometry, crs=self._obj.proj.crs) | |||
|
|
|||
| # coordinate geometry | |||
Member
There was a problem hiding this comment.
Can you include a comment here explaining what is happening with a link to the xarray issue? I'd like to see this as a temporary measure until it gets fixed in upstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a known bug with the xarray
2025.10.1version, Dataset/DataArray coordinates names that are different from the dimension names are not included in the columns when converting a Dataset/DataArray withto_dataframe().In this case, since
summary_geometrywas not same as the dimension name (i.e.geometry),summary_geometrycolumn was not included the thedfresulting aKeyErrorwhile trying to set geometry at;xvec/xvec/accessor.py
Lines 959 to 961 in a88c521