Implement IntoIterator for IMap and IArray via self-reference #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a variant of implementing
IntoIteratorvia self-reference to the respective collections (IArray,IMap).These implementations are done with the help of the ouroboros crate. This means it uses
unsafe(in the macro-generated code, I believe) to achieve self-reference. This may be undesired if fully safe code is wanted.From an API point, this solution seems ideal - any struct will be taken by ownership and allows for these
IntoIterstructs to outlive scope they are made in.The
IArrayimplementation is rewritten to the same approach for consistency. No breaking changes.Closes #68 because the two approaches are disjoint.