chore: migrate to Poetry and fix MLB API model fields #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert pyproject.toml to Poetry format - Add poetry.lock for reproducible builds - Update CI workflows to use Poetry: - Use snok/install-poetry action - Update actions/checkout to v4, setup-python to v5 - Add Python 3.11, 3.12 to feature branch test matrix - Move requests-mock to dev dependencies Build and publish to PyPI/TestPyPI unchanged.
- Add 'roundrobin' field to Standings model - Add 'inningspitchedpergame' field to AdvancedPitchingSplit model - Skip external 500 tests that depend on API behavior (covered by mocks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Migrate build system to Poetry for better dependency management, reproducible builds, and modernize CI. Also fix failing external tests due to new MLB API fields.
What
Convert from setuptools to Poetry
Update all CI workflows to use Poetry
Add Python 3.11, 3.12 to feature branch test matrix
Add missing MLB API fields:
Standings: roundrobin
AdvancedPitchingSplit: inningspitchedpergame, flyballpercentage
Skip flaky external 500 tests (API no longer returns 500, covered by mocks)
Tests
All 63 mock tests pass
External tests pass (118 passed, 2 skipped)
Risk and impact
Normal
Build system change affects how package is built/installed. Model changes are additive (optional fields). CI tested successfully on all Python versions.