Add service name source to trace stats#10653
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intomasterfrom Feb 20, 2026
Merged
Add service name source to trace stats#10653gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intomasterfrom
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~5dfc33ee8e, baseline=1.60.0-SNAPSHOT~20abae4712
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065429
Total [baseline] (8.775 s) : 0, 8774583
Agent [candidate] (1.065 s) : 0, 1064568
Total [candidate] (8.729 s) : 0, 8729218
section iast
Agent [baseline] (1.229 s) : 0, 1228701
Total [baseline] (9.39 s) : 0, 9389947
Agent [candidate] (1.243 s) : 0, 1242818
Total [candidate] (9.414 s) : 0, 9413657
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~5dfc33ee8e, baseline=1.60.0-SNAPSHOT~20abae4712
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (627.737 ms) : 0, 627737
BytebuddyAgent [candidate] (627.391 ms) : 0, 627391
AgentMeter [baseline] (29.064 ms) : 0, 29064
AgentMeter [candidate] (29.01 ms) : 0, 29010
GlobalTracer [baseline] (258.375 ms) : 0, 258375
GlobalTracer [candidate] (257.807 ms) : 0, 257807
AppSec [baseline] (33.027 ms) : 0, 33027
AppSec [candidate] (32.795 ms) : 0, 32795
Debugger [baseline] (62.871 ms) : 0, 62871
Debugger [candidate] (63.635 ms) : 0, 63635
Remote Config [baseline] (616.633 µs) : 0, 617
Remote Config [candidate] (621.997 µs) : 0, 622
Telemetry [baseline] (10.552 ms) : 0, 10552
Telemetry [candidate] (9.924 ms) : 0, 9924
Flare Poller [baseline] (5.672 ms) : 0, 5672
Flare Poller [candidate] (5.97 ms) : 0, 5970
section iast
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.22 ms) : 0, 1220
BytebuddyAgent [baseline] (793.812 ms) : 0, 793812
BytebuddyAgent [candidate] (804.809 ms) : 0, 804809
AgentMeter [baseline] (11.301 ms) : 0, 11301
AgentMeter [candidate] (11.391 ms) : 0, 11391
GlobalTracer [baseline] (247.547 ms) : 0, 247547
GlobalTracer [candidate] (249.393 ms) : 0, 249393
IAST [baseline] (26.789 ms) : 0, 26789
IAST [candidate] (27.11 ms) : 0, 27110
AppSec [baseline] (34.105 ms) : 0, 34105
AppSec [candidate] (34.221 ms) : 0, 34221
Debugger [baseline] (65.334 ms) : 0, 65334
Debugger [candidate] (65.491 ms) : 0, 65491
Remote Config [baseline] (530.561 µs) : 0, 531
Remote Config [candidate] (540.256 µs) : 0, 540
Telemetry [baseline] (8.571 ms) : 0, 8571
Telemetry [candidate] (8.676 ms) : 0, 8676
Flare Poller [baseline] (3.412 ms) : 0, 3412
Flare Poller [candidate] (3.46 ms) : 0, 3460
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~5dfc33ee8e, baseline=1.60.0-SNAPSHOT~20abae4712
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065327
Total [baseline] (10.987 s) : 0, 10986542
Agent [candidate] (1.067 s) : 0, 1067254
Total [candidate] (10.872 s) : 0, 10871662
section appsec
Agent [baseline] (1.241 s) : 0, 1241075
Total [baseline] (11.084 s) : 0, 11083688
Agent [candidate] (1.249 s) : 0, 1249126
Total [candidate] (11.123 s) : 0, 11122988
section iast
Agent [baseline] (1.233 s) : 0, 1233236
Total [baseline] (11.194 s) : 0, 11193814
Agent [candidate] (1.248 s) : 0, 1247905
Total [candidate] (11.139 s) : 0, 11139180
section profiling
Agent [baseline] (1.19 s) : 0, 1189637
Total [baseline] (10.943 s) : 0, 10942599
Agent [candidate] (1.191 s) : 0, 1190545
Total [candidate] (10.885 s) : 0, 10885420
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~5dfc33ee8e, baseline=1.60.0-SNAPSHOT~20abae4712
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (627.064 ms) : 0, 627064
BytebuddyAgent [candidate] (628.782 ms) : 0, 628782
AgentMeter [baseline] (29.147 ms) : 0, 29147
AgentMeter [candidate] (29.143 ms) : 0, 29143
GlobalTracer [baseline] (257.343 ms) : 0, 257343
GlobalTracer [candidate] (258.373 ms) : 0, 258373
AppSec [baseline] (32.997 ms) : 0, 32997
AppSec [candidate] (32.897 ms) : 0, 32897
Debugger [baseline] (66.386 ms) : 0, 66386
Debugger [candidate] (64.944 ms) : 0, 64944
Remote Config [baseline] (613.034 µs) : 0, 613
Remote Config [candidate] (620.715 µs) : 0, 621
Telemetry [baseline] (9.916 ms) : 0, 9916
Telemetry [candidate] (10.674 ms) : 0, 10674
Flare Poller [baseline] (4.561 ms) : 0, 4561
Flare Poller [candidate] (4.55 ms) : 0, 4550
section appsec
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.223 ms) : 0, 1223
BytebuddyAgent [baseline] (658.387 ms) : 0, 658387
BytebuddyAgent [candidate] (663.628 ms) : 0, 663628
AgentMeter [baseline] (11.963 ms) : 0, 11963
AgentMeter [candidate] (12.067 ms) : 0, 12067
GlobalTracer [baseline] (258.685 ms) : 0, 258685
GlobalTracer [candidate] (260.205 ms) : 0, 260205
IAST [baseline] (25.36 ms) : 0, 25360
IAST [candidate] (25.59 ms) : 0, 25590
AppSec [baseline] (168.565 ms) : 0, 168565
AppSec [candidate] (168.889 ms) : 0, 168889
Debugger [baseline] (66.865 ms) : 0, 66865
Debugger [candidate] (67.267 ms) : 0, 67267
Remote Config [baseline] (664.854 µs) : 0, 665
Remote Config [candidate] (655.977 µs) : 0, 656
Telemetry [baseline] (9.54 ms) : 0, 9540
Telemetry [candidate] (9.585 ms) : 0, 9585
Flare Poller [baseline] (3.748 ms) : 0, 3748
Flare Poller [candidate] (3.751 ms) : 0, 3751
section iast
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.217 ms) : 0, 1217
BytebuddyAgent [baseline] (796.976 ms) : 0, 796976
BytebuddyAgent [candidate] (807.713 ms) : 0, 807713
AgentMeter [baseline] (11.318 ms) : 0, 11318
AgentMeter [candidate] (11.545 ms) : 0, 11545
GlobalTracer [baseline] (248.066 ms) : 0, 248066
GlobalTracer [candidate] (250.056 ms) : 0, 250056
IAST [baseline] (26.908 ms) : 0, 26908
IAST [candidate] (27.335 ms) : 0, 27335
AppSec [baseline] (33.832 ms) : 0, 33832
AppSec [candidate] (31.817 ms) : 0, 31817
Debugger [baseline] (66.147 ms) : 0, 66147
Debugger [candidate] (69.295 ms) : 0, 69295
Remote Config [baseline] (552.872 µs) : 0, 553
Remote Config [candidate] (527.089 µs) : 0, 527
Telemetry [baseline] (8.672 ms) : 0, 8672
Telemetry [candidate] (8.572 ms) : 0, 8572
Flare Poller [baseline] (3.492 ms) : 0, 3492
Flare Poller [candidate] (3.407 ms) : 0, 3407
section profiling
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (680.488 ms) : 0, 680488
BytebuddyAgent [candidate] (681.384 ms) : 0, 681384
AgentMeter [baseline] (8.553 ms) : 0, 8553
AgentMeter [candidate] (8.532 ms) : 0, 8532
GlobalTracer [baseline] (216.258 ms) : 0, 216258
GlobalTracer [candidate] (216.371 ms) : 0, 216371
AppSec [baseline] (32.405 ms) : 0, 32405
AppSec [candidate] (32.49 ms) : 0, 32490
Debugger [baseline] (66.975 ms) : 0, 66975
Debugger [candidate] (67.327 ms) : 0, 67327
Remote Config [baseline] (630.76 µs) : 0, 631
Remote Config [candidate] (631.597 µs) : 0, 632
Telemetry [baseline] (9.086 ms) : 0, 9086
Telemetry [candidate] (9.037 ms) : 0, 9037
Flare Poller [baseline] (3.743 ms) : 0, 3743
Flare Poller [candidate] (3.747 ms) : 0, 3747
ProfilingAgent [baseline] (99.578 ms) : 0, 99578
ProfilingAgent [candidate] (99.162 ms) : 0, 99162
Profiling [baseline] (100.161 ms) : 0, 100161
Profiling [candidate] (99.728 ms) : 0, 99728
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 6 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~5dfc33ee8e, baseline=1.60.0-SNAPSHOT~20abae4712
dateFormat X
axisFormat %s
section baseline
no_agent (1.173 ms) : 1162, 1184
. : milestone, 1173,
iast (3.158 ms) : 3112, 3205
. : milestone, 3158,
iast_FULL (5.732 ms) : 5674, 5789
. : milestone, 5732,
iast_GLOBAL (3.468 ms) : 3406, 3529
. : milestone, 3468,
profiling (2.158 ms) : 2139, 2177
. : milestone, 2158,
tracing (1.843 ms) : 1827, 1860
. : milestone, 1843,
section candidate
no_agent (1.167 ms) : 1156, 1179
. : milestone, 1167,
iast (3.231 ms) : 3189, 3273
. : milestone, 3231,
iast_FULL (5.957 ms) : 5897, 6017
. : milestone, 5957,
iast_GLOBAL (3.578 ms) : 3514, 3643
. : milestone, 3578,
profiling (2.389 ms) : 2363, 2415
. : milestone, 2389,
tracing (1.757 ms) : 1742, 1771
. : milestone, 1757,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~5dfc33ee8e, baseline=1.60.0-SNAPSHOT~20abae4712
dateFormat X
axisFormat %s
section baseline
no_agent (18.01 ms) : 17827, 18192
. : milestone, 18010,
appsec (19.742 ms) : 19538, 19947
. : milestone, 19742,
code_origins (17.834 ms) : 17660, 18009
. : milestone, 17834,
iast (17.689 ms) : 17516, 17863
. : milestone, 17689,
profiling (18.669 ms) : 18485, 18852
. : milestone, 18669,
tracing (17.327 ms) : 17156, 17498
. : milestone, 17327,
section candidate
no_agent (18.015 ms) : 17830, 18199
. : milestone, 18015,
appsec (18.395 ms) : 18207, 18582
. : milestone, 18395,
code_origins (17.834 ms) : 17655, 18013
. : milestone, 17834,
iast (18.314 ms) : 18129, 18500
. : milestone, 18314,
profiling (19.688 ms) : 19486, 19890
. : milestone, 19688,
tracing (17.338 ms) : 17165, 17510
. : milestone, 17338,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~5dfc33ee8e, baseline=1.60.0-SNAPSHOT~20abae4712
dateFormat X
axisFormat %s
section baseline
no_agent (15.017 s) : 15017000, 15017000
. : milestone, 15017000,
appsec (14.742 s) : 14742000, 14742000
. : milestone, 14742000,
iast (18.082 s) : 18082000, 18082000
. : milestone, 18082000,
iast_GLOBAL (17.786 s) : 17786000, 17786000
. : milestone, 17786000,
profiling (14.774 s) : 14774000, 14774000
. : milestone, 14774000,
tracing (14.635 s) : 14635000, 14635000
. : milestone, 14635000,
section candidate
no_agent (15.364 s) : 15364000, 15364000
. : milestone, 15364000,
appsec (14.9 s) : 14900000, 14900000
. : milestone, 14900000,
iast (18.187 s) : 18187000, 18187000
. : milestone, 18187000,
iast_GLOBAL (17.985 s) : 17985000, 17985000
. : milestone, 17985000,
profiling (14.978 s) : 14978000, 14978000
. : milestone, 14978000,
tracing (14.901 s) : 14901000, 14901000
. : milestone, 14901000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~5dfc33ee8e, baseline=1.60.0-SNAPSHOT~20abae4712
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (3.742 ms) : 3521, 3963
. : milestone, 3742,
iast (2.25 ms) : 2181, 2319
. : milestone, 2250,
iast_GLOBAL (2.289 ms) : 2220, 2358
. : milestone, 2289,
profiling (2.072 ms) : 2018, 2126
. : milestone, 2072,
tracing (2.062 ms) : 2008, 2115
. : milestone, 2062,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (3.8 ms) : 3580, 4020
. : milestone, 3800,
iast (2.244 ms) : 2175, 2313
. : milestone, 2244,
iast_GLOBAL (2.302 ms) : 2232, 2372
. : milestone, 2302,
profiling (2.08 ms) : 2025, 2136
. : milestone, 2080,
tracing (2.055 ms) : 2002, 2108
. : milestone, 2055,
|
Contributor
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Same as #10636 that got closed by mistake :(
This PR continues the work begun by #10607 by adding the service name source to the stats.
The source is taking part to the bucket aggregation key and, if present, will be serialised under the srv_src tag (see agent PR)
This allows trace stats to carry additional context about service naming decisions without altering existing span behavior.
Also, the hashcode calculation in MetricsKey sounded not correct due to recent changes so I took the occasion to fix it and make more explicit by using constant folded multiplications
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.