Don't accept NaN slit widths #413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
==========================================
- Coverage 27.77% 27.76% -0.01%
==========================================
Files 72 72
Lines 9883 9885 +2
Branches 1318 1319 +1
==========================================
Hits 2745 2745
- Misses 7044 7046 +2
Partials 94 94 |
tieneupin
approved these changes
Nov 27, 2024
Contributor
tieneupin
left a comment
tieneupin
left a comment
There was a problem hiding this comment.
Looks good. My understanding is that this dict is passed to the DCParameters Pydantic model for validation, hence why it becomes None, right?
d-j-hatton
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the 200keV systems we see errors on
start_data_collectionposts for tomography due to NaN slit widths.If the slit width is NaN we should just not insert it and allow it to default to None.