-
Notifications
You must be signed in to change notification settings - Fork 1
Added FastAPI endpoint to trigger image alignment and merging job for CLEM workflow and updated function parameters #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5147daf
Moved 'TiffSeriesInfo' Pydantic model to the CLEM API page
tieneupin 324531b
Added endpoint to enable manual triggering of 'align-and-merge' step …
tieneupin ce9d13b
Enabled image alignment when triggering 'align-and-merge' job in CLEM…
tieneupin 23bd2b6
Added option to crop image stacks and process only central frames
tieneupin b774a65
CLEM image alignment and merging should be considered a processing st…
tieneupin c28433f
Updated input parameters for the align and merge CLEM workflow, and u…
tieneupin e6aa5cd
Defined align and merge processing parameters separately to be passed…
tieneupin d43ca95
Renamed spa_params to processing_params, to store default processing …
tieneupin 8bd08be
Moved default processing parameters for align-and-merge CLEM workflow…
tieneupin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
src/murfey/util/spa_params.py → src/murfey/util/processing_params.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,9 +25,10 @@ def submit_cluster_request( | |
| images: list[Path], | ||
| metadata: Path, | ||
| # Optional processing parameters | ||
| align_self: Optional[str] = None, | ||
| flatten: Optional[Literal["min", "max", "mean"]] = "mean", | ||
| align_across: Optional[str] = None, | ||
| crop_to_n_frames: Optional[int] = None, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As above. Something to consider |
||
| align_self: Literal["enabled", ""] = "", | ||
| flatten: Literal["mean", "min", "max", ""] = "mean", | ||
| align_across: Literal["enabled", ""] = "", | ||
| # Optional session parameters | ||
| messenger: Optional[TransportManager] = None, | ||
| ): | ||
|
|
@@ -64,6 +65,7 @@ def submit_cluster_request( | |
| "series_name": series_name, | ||
| "images": [str(file) for file in images], | ||
| "metadata": str(metadata), | ||
| "crop_to_n_frames": crop_to_n_frames, | ||
| "align_self": align_self, | ||
| "flatten": flatten, | ||
| "align_across": align_across, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted on the cryoemservices PR, these could possibly default to something else rather than None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these still apply after our discussion as a group earlier, or are you have to have them as None?