Remove TUI app components from Murfey #715
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #715 +/- ##
==========================================
+ Coverage 40.30% 42.48% +2.18%
==========================================
Files 99 94 -5
Lines 11602 10346 -1256
Branches 1553 1345 -208
==========================================
- Hits 4676 4396 -280
+ Misses 6708 5733 -975
+ Partials 218 217 -1 🚀 New features to boost your workflow:
|
…ment-server' as a key is no longer needed
stephen-riggs
left a comment
stephen-riggs
left a comment
There was a problem hiding this comment.
Looks good to me
If you've not already done so it's probably worth running the instrument server with this version just to check nothing unexpected happens
| "fastapi[standard-no-fastapi-cloud-cli]>=0.116.0", | ||
| "pydantic>=2", | ||
| "pydantic-settings", | ||
| "python-jose", |
There was a problem hiding this comment.
Does this need to be python-jose[cryptography] like it was before or is that not needed any more?
There was a problem hiding this comment.
I had a look at the original repo, and the cryptography optional dependency installs only cryptography. python-jose can thus be safely moved under our general dependencies.
| settling_time: float = 60, | ||
| appearance_time: float | None = None, | ||
| substrings_blacklist: dict[str, dict] = {}, | ||
| substrings_blacklist: dict[str, list[str]] = {}, |
There was a problem hiding this comment.
What caused the type to change here?
There was a problem hiding this comment.
This was an actual type hinting mistake on my part that went uncaught by pre-commit previously!
substrings_blacklist has the form:
{
"directories": ["string1", "string2", ...],
"files": ["string1", "string2", ...],
}
so its type should be dict[str, list[str]].
The TUI app has not seen use for a good few months, and has not been updated now that the instrument server workflow is mature and working smoothly. This PR removes all files, folders, and class attributes that are refer to the TUI app or call things from it, substantially reducing the presence of unmaintained/deprecated code in our repo.