Chore: Update Modals to SurfaceView

[devanshkansagra]

Description

Update RocketChat Apps-Engine to a newer compatible version and remove deprecated methods like ModalView to resolve issues with modals not functioning properly.

Closing issues

• Assign and share issues of a repository through command '/github issues' not working #146
• [BUG]: The share issues feature is not working. #131

Tasks

• Remove all possible deprecated methods of ModalView
• Add new Updated Methods of SurfaceView

Video Proof

Screencast.from.16-01-25.09.10.41.PM.IST.webm

Note: The video will be updated once the other modals are updated as per the commit.

[devanshkansagra]

Hey @samad-yar-khan, I have found a small bug, in this bug there improper displaying of merge and approve button in pullDetails Modal. Meaning the merge and approve button was showing up even when the pr is merged or having conflicts, or even the user has no access of merging code to the repository, and pr is merged or closed

so in this fix I have added some conditions such that merge button should display if the user has merge access and that pr has no conflicts. in case of conflicts or if that user is not a maintainer then that button will not show up. the approve button will only show up when the pr is not merged

Video demo

2025-01-18.00-47-49.mp4

This similar functionality will also be obtained when executing this command /github username/reponame pulls <pr-number>

[devanshkansagra]

Hey @samad-yar-khan, this pull request is now ready for review. It includes a significant amount of work, so a thorough review might take some time. I’d be happy to assist with any clarifications or additional details if needed.

Creating a detailed video to showcase all the possible cases can take a long time, till then (if you are available and free) you can fetch this branch and deploy it to test the changes on your end and soon I will update the description video.

Thanks.