WP_Icons_Registry: make Gutenberg-side iteration easier#11047
Draft
mcsf wants to merge 2 commits intoWordPress:trunkfrom
Draft
WP_Icons_Registry: make Gutenberg-side iteration easier#11047mcsf wants to merge 2 commits intoWordPress:trunkfrom
mcsf wants to merge 2 commits intoWordPress:trunkfrom
Conversation
This will make it easier to iterate on WP_Icons_Registry in Gutenberg by allowing us to define derived classes (Gutenberg_Icons_Registry extends WP_Icons_Registry) and inherit any methods or constants that are untouched by referenced by the derived class.
This is so that the Gutenberg plugin can easily provide new core icons in between major WordPress releases. On the other hand, we will probably end up redefining whole methods on the Gutenberg side as we improve WP_Icons_Registry, so it may be moot to introduce a filter just for the manifest file.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/64651
Context: WordPress/gutenberg#75878
protectedvisibility. It would be nice to include in 7.0 Beta.Trac ticket:
Use of AI Tools
None
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.