Skip to content

WP_Icons_Registry: make Gutenberg-side iteration easier #11047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcsf wants to merge 4 commits into from
+7 −7
Closed

WP_Icons_Registry: make Gutenberg-side iteration easier #11047

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e8bbca0
WP_Icons_Registry: Make private methods & constants protected
mcsf Feb 25, 2026
40dba1d
WP_Icons_Registry: Add filter icons_registry_core_manifest
mcsf Feb 25, 2026
6872a21
Revert "WP_Icons_Registry: Add filter icons_registry_core_manifest"
mcsf Feb 26, 2026
59c9e03
Merge branch 'trunk' into add/icons-api/class-filters
mcsf Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/wp-includes/class-wp-icons-registry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,20 +18,20 @@ class WP_Icons_Registry {
*
* @var array[]
*/
private $registered_icons = array();
protected $registered_icons = array();


/**
* Container for the main instance of the class.
*
* @var WP_Icons_Registry|null
*/
private static $instance = null;
protected static $instance = null;

/**
* Constructor.
*
* WP_Icons_Registry is a singleton class, so keep this private.
* WP_Icons_Registry is a singleton class, so keep this protected.
*
* For 7.0, the Icons Registry is closed for third-party icon registry,
* serving only a subset of core icons.
Expand All @@ -40,7 +40,7 @@ class WP_Icons_Registry {
* SVG files and as entries in a single manifest file. On init, the
* registry is loaded with those icons listed in the manifest.
*/
private function __construct() {
protected function __construct() {
$icons_directory = __DIR__ . '/icons/';
$icons_directory = trailingslashit( $icons_directory );
$manifest_path = $icons_directory . 'manifest.php';
Expand Down Expand Up @@ -101,7 +101,7 @@ private function __construct() {
* }
* @return bool True if the icon was registered with success and false otherwise.
*/
private function register( $icon_name, $icon_properties ) {
protected function register( $icon_name, $icon_properties ) {
if ( ! isset( $icon_name ) || ! is_string( $icon_name ) ) {
_doing_it_wrong(
__METHOD__,
Expand Down Expand Up @@ -188,7 +188,7 @@ private function register( $icon_name, $icon_properties ) {
* @param string $icon_content The icon SVG content to sanitize.
* @return string The sanitized icon SVG content.
*/
private function sanitize_icon_content( $icon_content ) {
protected function sanitize_icon_content( $icon_content ) {
$allowed_tags = array(
'svg' => array(
'class' => true,
Expand Down Expand Up @@ -223,7 +223,7 @@ private function sanitize_icon_content( $icon_content ) {
* @param string $icon_name Icon name including namespace.
* @return string|null The content of the icon, if found.
*/
private function get_content( $icon_name ) {
protected function get_content( $icon_name ) {
if ( ! isset( $this->registered_icons[ $icon_name ]['content'] ) ) {
$content = file_get_contents(
$this->registered_icons[ $icon_name ]['filePath']
Expand Down
Loading