refactor: change DefaultQuantities to use property initializer#1575
refactor: change DefaultQuantities to use property initializer#1575angularsen wants to merge 1 commit intomasterfrom
Conversation
|
I believe there was a reason for this- if we use an eager initializer here, we couldn't allow for re-configuring the "default". |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1575 +/- ##
======================================
Coverage 93% 93%
======================================
Files 311 311
Lines 28781 28781
======================================
Hits 26864 26864
Misses 1917 1917 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Right, but I thought the idea was that this is the built-in provider. Any customizations happen further out, such as in |
|
The so for a particular quantity we can override the default setter, by constructing it using the provided customization function. The action using the Quantity.Provider would end up constructing the QuantityInfo's before we are able to do anything. |
|
I've merged #1576 |
Fixup of #1555