refactor: rename to Quantity.DefaultProvider.Quantities#1576
Conversation
|
Optionally merge #1575 first, this PR has both changes. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1576 +/- ##
======================================
Coverage 93% 93%
======================================
Files 311 311
Lines 28780 28781 +1
======================================
+ Hits 26863 26864 +1
Misses 1917 1917 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
UnitsNet/QuantityInfoLookup.cs
Outdated
| internal class QuantityInfoLookup | ||
| { | ||
| private readonly QuantityInfo[] _quantities; | ||
| private readonly IReadOnlyList<QuantityInfo> _quantities; |
There was a problem hiding this comment.
there is a slight performance overhead of using the interface on the private field, but if you prefer clarity- it's fine by me..
There was a problem hiding this comment.
This change was collateral damage, I'll revert it. The idea was to accept IReadOnlyList as input and reuse instance if compatible, but I'll do the same for array instead.
|
Ok, i'm fine with the static initializer- we'll change it back when we start actually configuring the defaults.. |
|
Sounds good |
Fixup of #1555