Skip to content

Improve error message for missing tables with clearer diagnostics #19873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shivfun99 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve error message for missing tables with clearer diagnostics #19873

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
387de8b
UX: improve diagnostics for unresolved table references
ArjunNair99 Jan 18, 2026
0939c8f
Merge branch 'main' into ux-table-suggestions
Shivfun99 Jan 18, 2026
ba35853
Merge branch 'main' into ux-table-suggestions
Shivfun99 Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions datafusion/sql/src/relation/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ use datafusion_common::tree_node::{Transformed, TreeNode};
use datafusion_common::{
DFSchema, Diagnostic, Result, Span, Spans, TableReference, not_impl_err, plan_err,
};

use datafusion_expr::builder::subquery_alias;
use datafusion_expr::planner::{
PlannedRelation, RelationPlannerContext, RelationPlanning,
Expand Down Expand Up @@ -181,6 +182,7 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
let table_ref = self.object_name_to_table_reference(name)?;
let table_name = table_ref.to_string();
let cte = planner_context.get_cte(&table_name);

(
match (
cte,
Expand All @@ -194,11 +196,14 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
)?
.build(),
(None, Err(e)) => {
let e = e.with_diagnostic(Diagnostic::new_error(
format!("table '{table_ref}' not found"),
let input = table_ref.table().to_string();

let diagnostic = Diagnostic::new_error(
format!("table '{input}' not found"),
Span::try_from_sqlparser_span(relation_span),
));
Err(e)
);

Err(e.with_diagnostic(diagnostic))
}
}?,
alias,
Expand Down