Merged
Conversation
nox
commented
Jul 31, 2023
This comment was marked as outdated.
This comment was marked as outdated.
nox
force-pushed
the
async
branch
4 times, most recently
from
3691580 to
8c6fd07
Compare
nox
force-pushed
the
async
branch
8 times, most recently
from
31af102 to
71dad44
Compare
This comment was marked as outdated.
This comment was marked as outdated.
nox
force-pushed
the
async
branch
6 times, most recently
from
2694e68 to
e5bb7c6
Compare
Collaborator
Author
|
I removed the biggest breaking change (the removal of |
nox
force-pushed
the
async
branch
2 times, most recently
from
ed4142d to
abf3ec4
Compare
Collaborator
Author
|
The one missing thing from the PR is tests for |
nox
changed the title
Noah-Kennedy
left a comment
Noah-Kennedy
left a comment
There was a problem hiding this comment.
I'm a bit nervous about a few things I see, and I'd like to go over this more thoroughly tomorrow or Monday.
nox
force-pushed
the
async
branch
2 times, most recently
from
df99127 to
2ba3db5
Compare
Noah-Kennedy
approved these changes
Sep 14, 2023
cjpatton
requested changes
Sep 14, 2023
cjpatton
approved these changes
Sep 14, 2023
nox
force-pushed
the
async
branch
4 times, most recently
from
032898f to
f837aeb
Compare
ghedo
reviewed
Oct 6, 2023
These lists are hardcoded and the calls have no business failing in the first place.
These two new kinds of methods immediately return a MidHandshakeSslStream instead of actually initiating a handshake. This greatly simplifies loops around MidHandshakeSslStream::WouldBlock.
This encapsulates a bit better the unsafety of task context management to invoke async code from inside boring.
To handle lifetimes better and allow returning a &mut SslRef from the client hello struct passed to the closure from SslContextBuilder::set_select_certificate_callback, we make the ClientHello struct itself own a reference to the FFI client hello struct.
We introduce tokio_boring::SslContextBuilderExt, with 2 methods: * set_async_select_certificate_callback * set_async_private_key_method
ghedo
approved these changes
Oct 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.