Remove all connect and accept functions#142
Open
nox wants to merge 1 commit intocloudflare:masterfrom
Open
Conversation
nox
force-pushed
the
revamp-handshake-entrypoints
branch
7 times, most recently
from
69081d5 to
5a93ea0
Compare
nox
force-pushed
the
revamp-handshake-entrypoints
branch
from
5a93ea0 to
756f807
Compare
nox
force-pushed
the
revamp-handshake-entrypoints
branch
from
756f807 to
7942e71
Compare
This was referenced Oct 9, 2023
nox
force-pushed
the
revamp-handshake-entrypoints
branch
from
7942e71 to
5f74ec0
Compare
Those functions were blurring the line between setup failures (which are caused by the developer misusing the API) and actual failures encountered on the stream while trying to achieve the TLS handshake, especially on SslConnector and SslAcceptor. Removing them allows for the removal of HandshakeError, as the HandshakeError::SetupFailure variant becomes useless, and there is no real need to distinguish in that error type between Failure and WouldBlock when we can just check the error stored in MidHandshakeSslStream. This then allow us to simplify tokio_boring's own entry points, also making them distinguish between setup failures and failures on the stream.
nox
force-pushed
the
revamp-handshake-entrypoints
branch
from
5f74ec0 to
655c6fe
Compare
nox
changed the title
Collaborator
Author
|
I've changed the PR to be about removing every entry point that returned |
Collaborator
|
Let's leave it for v6. Getting boring-sys v5 out ASAP is important. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those functions were blurring the line between setup failures (which are caused by the developer misusing the API) and actual failures encountered on the stream while trying to achieve the TLS handshake, especially on
SslConnectorandSslAcceptor.Removing them allows for the removal of
HandshakeError, as theHandshakeError::SetupFailurevariant becomes useless, and there is no real need to distinguish in that error type betweenFailureandWouldBlockwhen we can just check the error stored inMidHandshakeSslStream.This then allow us to simplify
tokio_boring's own entry points, also making them distinguish between setup failures and failures on the stream.