You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Potential encoding/terminal rendering issue mycli/packages/special/main.py:169 introduces a non‑ASCII em dash in the status string (Docs index — ...). In some terminals (especially Windows w/ non‑UTF‑8 codepages), this can display as ? or break alignment. Consider using ASCII - or -- to avoid encoding regressions.
Missing test coverage
There’s no test asserting the inline help footer/status output. A small test around show_help()’s SQLResult.status would lock in the behavior and prevent regressions (e.g., verify it contains DOCS_URL).
No security issues found.
Open questions / assumptions
I didn’t find any existing tests for help output in this repo; if they live elsewhere, point me to them and I’ll re‑evaluate.
Suggestions (if you want to follow up)
Add a targeted unit test for show_help() status content.
Replace the em dash with ASCII to avoid encoding edge cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Show docs URL in footer after inline help.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).