-
Notifications
You must be signed in to change notification settings - Fork 29
Docker Compose v5 requires buildx #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
|
https://github.com/docker/packaging/actions/runs/19368420725/job/55417636835?pr=311#step:9:407 I think we need to update the verify step, I will take a look |
| make | ||
|
|
||
| Package: docker-compose-plugin | ||
| Priority: optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you remove this deliberately? I think it's recommended (or even mandatory) to include it (as it's not a debian system package that's required)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was declared twice in this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! Thanks I didn't spot that 👍
| . | ||
| The binary can also be run standalone as a direct replacement for | ||
| Docker Compose V1 ('docker-compose'). | ||
| Homepage: https://github.com/docker/compose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question for this one; was this removed on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same, already set on the top of this file
|
So I'm wondering is if we should make it
The
|
|
cc @tianon perhaps you have thoughts as well with your insight in common recommendations for this from a packaging perspective. |
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
|
Agreed that what Debian calls "
|
Next Compose release (v5.0.0) will require Buildx to run
compose buildandcompose up --buildcommandsalso removed duplicated entry in deb/control