Skip to content

Conversation

@ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Nov 14, 2025

Next Compose release (v5.0.0) will require Buildx to run compose build and compose up --build commands

also removed duplicated entry in deb/control

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof requested a review from a team as a code owner November 14, 2025 14:57
@crazy-max
Copy link
Member

https://github.com/docker/packaging/actions/runs/19368420725/job/55417636835?pr=311#step:9:407

I think we need to update the verify step, I will take a look

make

Package: docker-compose-plugin
Priority: optional
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you remove this deliberately? I think it's recommended (or even mandatory) to include it (as it's not a debian system package that's required)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was declared twice in this file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Thanks I didn't spot that 👍

.
The binary can also be run standalone as a direct replacement for
Docker Compose V1 ('docker-compose').
Homepage: https://github.com/docker/compose
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question for this one; was this removed on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, already set on the top of this file

@thaJeztah
Copy link
Member

So I'm wondering is if we should make it Requires; bare with me;

  • Recommends is already a strong dependency; package managers by default will install the dependency
  • BUT allow explicitly opting-out (--no-install-recommends)
  • For the docker CLI we have Recommends for buildx and compose; in most setups, this means that installing the CLI will also install compose and buildx UNLESS explicitly opted-out;
    Recommends: docker-buildx-plugin,
    docker-compose-plugin
    Suggests: docker-model-plugin

The opt-out option allows a more minimal setup, for example in a production environment where containers are deployed from images that exist in the registry, but never expected to be built. Making buildx Required for compose means that implicitly the Recommends in the CLI is also changed to Required;

  • Without buildx installed, is compose able to do a docker compose up if the compose-file doesn't have a build ?
  • What does docker compose up do if the image referenced is available in the registry, and no explicit --build is passed on docker compose up ?
  • ☝️ this would be in a scenario where the compose file has a build, but only intended for developer situations, and in production it would not do a build, only a docker pull of the image(s) referenced.

@thaJeztah
Copy link
Member

cc @tianon perhaps you have thoughts as well with your insight in common recommendations for this from a packaging perspective.

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max requested a review from a team as a code owner November 16, 2025 20:38
@crazy-max crazy-max requested review from glours and removed request for a team November 16, 2025 20:38
@tianon
Copy link
Contributor

tianon commented Nov 17, 2025

Agreed that what Debian calls "Recommends" is the appropriate relationship here:

https://www.debian.org/doc/debian-policy/ch-relationships.html#binary-dependencies-depends-recommends-suggests-enhances-pre-depends

Recommends

This declares a strong, but not absolute, dependency.

The Recommends field should list packages that would be found together with this one in all but unusual installations.

@ndeloof ndeloof closed this Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants