Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions pkg/compose/deb/control
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,12 @@ Build-Depends: bash,
make

Package: docker-compose-plugin
Priority: optional
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you remove this deliberately? I think it's recommended (or even mandatory) to include it (as it's not a debian system package that's required)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was declared twice in this file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Thanks I didn't spot that 👍

Architecture: linux-any
Recommends: docker-buildx-plugin (>= 0.17.0)
Depends: docker-buildx-plugin (>= 0.17.0)
Enhances: docker-ce-cli
Description: Docker Compose (V2) plugin for the Docker CLI.
.
This plugin provides the 'docker compose' subcommand.
.
The binary can also be run standalone as a direct replacement for
Docker Compose V1 ('docker-compose').
Homepage: https://github.com/docker/compose
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question for this one; was this removed on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, already set on the top of this file

2 changes: 1 addition & 1 deletion pkg/compose/rpm/docker-compose-plugin.spec
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Vendor: Docker
Packager: Docker <support@docker.com>

Enhances: docker-ce-cli
Recommends: docker-buildx-plugin >= 0.17.0
Requires: docker-buildx-plugin >= 0.17.0

BuildRequires: bash
BuildRequires: make
Expand Down
2 changes: 1 addition & 1 deletion pkg/compose/verify.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ RUN --mount=from=bin,target=/build <<EOT
(
set -x
dpkg-deb --info $package
dpkg -i $package
dpkg -i --ignore-depends=docker-buildx-plugin $package
)
done
set -x
Expand Down