Skip to content

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Jan 28, 2026

Fixes #35004

We show arrays with primitive values JSON.stringifyed in the performance tracks. However, bigint is not accepted by JSON.stringify so we have to treat arrays with these values as complex.

We could implement a replacer that stringifies bigint. A replacer would be considerably slower in latest versions of v8

@meta-cla meta-cla bot added the CLA Signed label Jan 28, 2026
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jan 28, 2026
@react-sizebot
Copy link

Comparing: e66ef64...04673e5

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB +0.05% 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 608.67 kB 608.67 kB = 107.63 kB 107.63 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB +0.05% 1.88 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 674.60 kB 674.60 kB = 118.58 kB 118.58 kB
facebook-www/ReactDOM-prod.classic.js = 693.92 kB 693.92 kB = 121.98 kB 121.98 kB
facebook-www/ReactDOM-prod.modern.js = 684.31 kB 684.31 kB = 120.37 kB 120.37 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 04673e5

@eps1lon eps1lon requested a review from hoxyq January 28, 2026 10:00
@eps1lon eps1lon marked this pull request as ready for review January 28, 2026 10:00
@eps1lon eps1lon merged commit ff191f2 into facebook:main Jan 28, 2026
243 checks passed
@eps1lon eps1lon deleted the sebbie/perf-tracks-bigint branch January 28, 2026 10:54
github-actions bot pushed a commit that referenced this pull request Jan 28, 2026
github-actions bot pushed a commit that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: React 19 Uncaught TypeError: Do not know how to serialize a BigInt

3 participants