Opencmw-cpp compatibility #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the serialisation of `MimeType` to use the verbose media type instead of the short enum name to be in line with opencmw-java's behaviour. Example `application/octet-stream` instead of `BINARY`. Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Failure
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Failure
The url constructor will encode the individual parts of the url in its constructor. If the individual components are already percent encoded, the percent signs of the encdoded characters will themself be encoded. For example `http:://example.com/path/file.ext?type=foo/bar` would get the query part encoded to `type=foo%2252Fbar` instead of `type=foo/bar`. Note that which characters will be escaped in an url depends on the part, in other components the slash would need to be escaped. Fortunately this is already implemented in the uri implementation. Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
wirew0rm
force-pushed
the
opencmw-cpp-compat
branch
from
d2c1368 to
d95fd2f
Compare
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Failure
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Failure
wirew0rm
force-pushed
the
opencmw-cpp-compat
branch
from
d95fd2f to
9011364
Compare
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Error
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Error
There were some minor differences compared to the c++ implementation. This changes the java version to: - use a leading slash in the subscription topic - terminate mds subscription topics with a `#` to break prefix matching which would generate multiple updates Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
wirew0rm
force-pushed
the
opencmw-cpp-compat
branch
from
9011364 to
74ea0f1
Compare
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Error
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Error
Adds normalisation to the zmq subscription topic to account for differences in url representation. This makes sure that all unreserved characters are escaped and all query keyvalue pairs are sorted alphabetically, matching subscription topics generated by opencmw-cpp. Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
wirew0rm
force-pushed
the
opencmw-cpp-compat
branch
from
4d7771c to
e3a1106
Compare
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Error
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Error
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Error
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Error
RalphSteinhagen
approved these changes
Dec 10, 2025
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on a few differences that have emerged between opencmw-cpp and opencmw-java.
See the individual commits for descriptions and reasoning for the individual changes.
This will be followed up by a CI test which will verify against a binary from the opencmw-cpp repository to ensure that changes in individual repositories will stay compatible.
!fixes #223