set standard in ps1 files

[scotthart]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the C++ version used in the Windows build configurations by explicitly setting the C++ standard to C++17. This ensures consistency across different build environments and prevents potential compilation issues arising from varying C++ standard interpretations.

Highlights

• C++ Standard Enforcement: Explicitly set the C++ standard to C++17 in the cmake.ps1 and quickstart-cmake.ps1 build scripts for Windows.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the Windows CI build scripts to explicitly set the C++ standard to C++17. However, the repository's style guide specifies C++14 as the minimum supported version. To maintain C++14 compatibility and prevent the accidental introduction of newer language features, I've recommended setting the standard to C++14 in the build scripts to align with the documented minimum version.

[gemini-code-assist]

The repository style guide indicates that C++14 is the minimum supported standard. To ensure the codebase remains compatible with C++14, it's preferable to enforce this standard in the CI builds. Setting it to C++17 could allow features that are not C++14 compatible to be merged.

    "-DCMAKE_CXX_STANDARD=14",

References

1. The repository style guide (line 6) states that C++14 is the minimum supported C++ standard version. This change should align with that by setting the standard to 14, not 17, to enforce compatibility. ^(link)

[gemini-code-assist]

The repository style guide indicates that C++14 is the minimum supported standard. To ensure the codebase remains compatible with C++14, it's preferable to enforce this standard in the CI builds. Setting it to C++17 could allow features that are not C++14 compatible to be merged.

    "-DCMAKE_CXX_STANDARD=14"

References

1. The repository style guide (line 6) states that C++14 is the minimum supported C++ standard version. This change should align with that by setting the standard to 14, not 17, to enforce compatibility. ^(link)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.88%. Comparing base (9429a07) to head (385471a).
⚠️ Report is 2 commits behind head on prepare-for-v3.0.0.

Additional details and impacted files

@@                 Coverage Diff                 @@
##           prepare-for-v3.0.0   #15916   +/-   ##
===================================================
  Coverage               92.87%   92.88%           
===================================================
  Files                    2343     2343           
  Lines                  216117   216117           
===================================================
+ Hits                   200719   200730   +11     
+ Misses                  15398    15387   -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.