Skip to content

set standard in ps1 files #15916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
scotthart wants to merge 1 commit into
base: prepare-for-v3.0.0
Choose a base branch
from
+3 −1
Draft

set standard in ps1 files #15916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ci/kokoro/windows/builds/cmake.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ $cmake_args=@(
"-DVCPKG_OVERLAY_TRIPLETS=${project_root}/ci/kokoro/windows/triplets",
"-DCMAKE_C_COMPILER=cl.exe",
"-DCMAKE_CXX_COMPILER=cl.exe",
"-DCMAKE_CXX_STANDARD=17",
Copy link

@gemini-code-assist gemini-code-assist bot Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The repository style guide indicates that C++14 is the minimum supported standard. To ensure the codebase remains compatible with C++14, it's preferable to enforce this standard in the CI builds. Setting it to C++17 could allow features that are not C++14 compatible to be merged.

    "-DCMAKE_CXX_STANDARD=14",
References
  1. The repository style guide (line 6) states that C++14 is the minimum supported C++ standard version. This change should align with that by setting the standard to 14, not 17, to enforce compatibility. (link)

"-DGOOGLE_CLOUD_CPP_ENABLE_WERROR=ON",
"-DGOOGLE_CLOUD_CPP_ENABLE_CTYPE_CORD_WORKAROUND=ON",
"-DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded$<$<CONFIG:Debug>:Debug>",
Expand Down
3 changes: 2 additions & 1 deletion ci/kokoro/windows/builds/quickstart-cmake.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ $cmake_args=@(
"-DCMAKE_TOOLCHAIN_FILE=`"${vcpkg_root}/scripts/buildsystems/vcpkg.cmake`"",
"-DCMAKE_BUILD_TYPE=${env:CONFIG}",
"-DVCPKG_TARGET_TRIPLET=${env:VCPKG_TRIPLET}",
"-DCMAKE_CXX_COMPILER=cl.exe"
"-DCMAKE_CXX_COMPILER=cl.exe",
"-DCMAKE_CXX_STANDARD=17"
Copy link

@gemini-code-assist gemini-code-assist bot Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The repository style guide indicates that C++14 is the minimum supported standard. To ensure the codebase remains compatible with C++14, it's preferable to enforce this standard in the CI builds. Setting it to C++17 could allow features that are not C++14 compatible to be merged.

    "-DCMAKE_CXX_STANDARD=14"
References
  1. The repository style guide (line 6) states that C++14 is the minimum supported C++ standard version. This change should align with that by setting the standard to 14, not 17, to enforce compatibility. (link)

)

Write-Host "$(Get-Date -Format o) Configuring CMake with $cmake_args"
Expand Down