[Snyk] Security upgrade @backstage/plugin-search-common from 0.0.0-use.local to 0.3.1 #11883
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-WEBPACK-15235959 - https://snyk.io/vuln/SNYK-JS-WEBPACK-15235969
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, focuses on enhancing the project's security by updating a key dependency. The primary objective is to mitigate known Server-side Request Forgery vulnerabilities, thereby strengthening the application's resilience against potential security threats. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
WalkthroughThis PR modifies the dependency management strategy for the catalog-common plugin by changing how the Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant CatalogCommon as "catalog-common plugin"
participant SearchCommon as "plugin-search-common"
Note over CatalogCommon,SearchCommon: Dependency Version Change
rect rgb(255, 240, 240)
Note right of CatalogCommon: Before: workspace:^<br/>(local workspace reference)
end
rect rgb(240, 255, 240)
Note right of CatalogCommon: After: 0.3.1<br/>(pinned to specific version)
end
CatalogCommon->>SearchCommon: depends on (version 0.3.1)
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, aims to fix security vulnerabilities by changing the version of @backstage/plugin-search-common. However, the proposed change is incorrect and should not be merged. It replaces a local workspace dependency (workspace:^) with a pinned, outdated version (0.3.1) from the public registry. This is a major downgrade from the current workspace version (1.2.5) and breaks the monorepo's dependency management structure, which will likely cause build or runtime failures. The warning in the PR description about failing to update yarn.lock further indicates that this change introduces dependency conflicts. The underlying security issue needs to be addressed in a way that is compatible with the monorepo setup, likely by updating the vulnerable transitive dependency across the workspace.
| "@backstage/catalog-model": "workspace:^", | ||
| "@backstage/plugin-permission-common": "workspace:^", | ||
| "@backstage/plugin-search-common": "workspace:^" | ||
| "@backstage/plugin-search-common": "0.3.1" |
There was a problem hiding this comment.
This change replaces a workspace-local dependency with a pinned version from the public registry, which is a significant downgrade and breaks the monorepo's dependency structure.
-
Breaks Monorepo Structure: The
workspace:^protocol ensures that packages within this monorepo depend on each other's local source code. Changing this to a specific version0.3.1will cause this package to fetch an old, published version of@backstage/plugin-search-commonfrom npm, ignoring local changes and updates. Other dependencies like@backstage/catalog-modelcorrectly useworkspace:^. -
Major Downgrade: The version in the workspace for
@backstage/plugin-search-commonis1.2.5. Pinning to0.3.1is a major downgrade that will likely lead to build failures, runtime errors, or missing features, as it's a very old version.
While the intent is to fix a security vulnerability, this approach is incorrect and harmful. The underlying vulnerability should be addressed differently, perhaps by updating transitive dependencies within the monorepo, rather than by this downgrade. This change should be reverted.
| "@backstage/plugin-search-common": "0.3.1" | |
| "@backstage/plugin-search-common": "workspace:^" |
2 participants
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/catalog-common/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-WEBPACK-15235959
SNYK-JS-WEBPACK-15235969
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Server-side Request Forgery (SSRF)
EntelligenceAI PR Summary
This PR updates the dependency resolution strategy for
@backstage/plugin-search-commonin the catalog-common plugin.workspace:^to pinned version0.3.1