Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/catalog-common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-search-common": "workspace:^"
"@backstage/plugin-search-common": "0.3.1"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change replaces a workspace-local dependency with a pinned version from the public registry, which is a significant downgrade and breaks the monorepo's dependency structure.

  • Breaks Monorepo Structure: The workspace:^ protocol ensures that packages within this monorepo depend on each other's local source code. Changing this to a specific version 0.3.1 will cause this package to fetch an old, published version of @backstage/plugin-search-common from npm, ignoring local changes and updates. Other dependencies like @backstage/catalog-model correctly use workspace:^.

  • Major Downgrade: The version in the workspace for @backstage/plugin-search-common is 1.2.5. Pinning to 0.3.1 is a major downgrade that will likely lead to build failures, runtime errors, or missing features, as it's a very old version.

While the intent is to fix a security vulnerability, this approach is incorrect and harmful. The underlying vulnerability should be addressed differently, perhaps by updating transitive dependencies within the monorepo, rather than by this downgrade. This change should be reverted.

Suggested change
"@backstage/plugin-search-common": "0.3.1"
"@backstage/plugin-search-common": "workspace:^"

},
"devDependencies": {
"@backstage/cli": "workspace:^"
Expand Down
Loading