forked from SDA-SE/backstage
-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Security upgrade @backstage/plugin-search-common from 0.0.0-use.local to 0.3.1 #11883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
q1blue
wants to merge
1
commit into
master
Choose a base branch
from
snyk-fix-cb46be2403c156669ca12490b92f9186
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change replaces a workspace-local dependency with a pinned version from the public registry, which is a significant downgrade and breaks the monorepo's dependency structure.
Breaks Monorepo Structure: The
workspace:^protocol ensures that packages within this monorepo depend on each other's local source code. Changing this to a specific version0.3.1will cause this package to fetch an old, published version of@backstage/plugin-search-commonfrom npm, ignoring local changes and updates. Other dependencies like@backstage/catalog-modelcorrectly useworkspace:^.Major Downgrade: The version in the workspace for
@backstage/plugin-search-commonis1.2.5. Pinning to0.3.1is a major downgrade that will likely lead to build failures, runtime errors, or missing features, as it's a very old version.While the intent is to fix a security vulnerability, this approach is incorrect and harmful. The underlying vulnerability should be addressed differently, perhaps by updating transitive dependencies within the monorepo, rather than by this downgrade. This change should be reverted.