Skip to content

Conversation

@ubaidsk
Copy link
Collaborator

@ubaidsk ubaidsk commented Feb 22, 2025

No description provided.

// CHECK(r.ok);
// CHECK(r.result.type == PythonCompiler::EvalResult::struct_type);
// CHECK(e.aggregate_type_to_string(r.result) == "MyClass5(u_1=False, u_8=2, u_16=3, u_32=4, u_64=5)");
// }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This single ctest is commented out. I believe it is flaky (sometimes passes, sometimes fails).

@ubaidsk ubaidsk marked this pull request as ready for review February 22, 2025 17:56
@ubaidsk ubaidsk requested a review from certik February 22, 2025 18:09
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine for now.

@ubaidsk ubaidsk merged commit 8883d14 into lcompilers:main Mar 12, 2025
18 checks passed
@ubaidsk ubaidsk mentioned this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants