feat: add editor parameter to auth redirect URL #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtsiolis
requested review from
anisaoshafi,
skyrpex and
tiurin
as code owners
anisaoshafi
approved these changes
Feb 5, 2026
Collaborator
anisaoshafi
left a comment
anisaoshafi
left a comment
There was a problem hiding this comment.
Thanks for paving the way for supporting more editors 👏🏼
Member
Author
|
Thanks for taking a look, @anisa! I think we may don't need the editor param after all, see relevant discussion. @skyrpex Shall we close this? |
Collaborator
|
@gtsiolis this is still needed, but the parameter name must be "name", and we also have to edit some environment variables that hardcode the name to "VSCode". |
Collaborator
|
I can do the necessary changes on Monday. |
Collaborator
|
I forgot that you already started the changes here 🤦🏻 I ended up with this #81. |
Collaborator
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add the
editorquery parameter to the auth redirect URL to allow the web app to redirect back to the correct editor (VS Code or VS Code Insiders) after authentication.See https://github.com/localstack/localstack-web/pull/2101#issuecomment-3849449650 for more context.