Skip to content

feat: add editor parameter to auth redirect URL #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gtsiolis wants to merge 1 commit into from
Closed

feat: add editor parameter to auth redirect URL #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/utils/authenticate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@
// TODO: Gather environment variables in a safer way - e.g. during extension activation
// biome-ignore lint/style/noNonNullAssertion: false positive
const url = new URL(process.env.LOCALSTACK_WEB_AUTH_REDIRECT!);
url.searchParams.set("editor", env.uriScheme);
url.searchParams.set("windowId", redirectSearchParams.get("windowId") ?? "");

const selection = await window.showInformationMessage(
Expand Down Expand Up @@ -113,7 +114,7 @@

outputChannel.error(error);

window

Check warning on line 117 in src/utils/authenticate.ts

View workflow job for this annotation

GitHub Actions / Lint 

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
.showErrorMessage(
`Failed to save auth token to ${LOCALSTACK_AUTH_FILENAME_READABLE}`,
"View Logs",
Expand Down
Loading