Fix StdioServerTransportTests to use Debug logging level instead of Trace#1209
Merged
stephentoub merged 2 commits intomainfrom Jan 29, 2026
Merged
Fix StdioServerTransportTests to use Debug logging level instead of Trace#1209stephentoub merged 2 commits intomainfrom
stephentoub merged 2 commits intomainfrom
Conversation
…g level Address feedback from PR #1191: The class-level LoggerFactory override was removed from the constructor (now uses base class default of Debug). The trace-level logging tests now create their own local MockLoggerProvider and trace-level LoggerFactory to properly test Trace-level logging without affecting other tests. Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address comment from merged PR 1191
Fix StdioServerTransportTests to use Debug logging level instead of Trace
Jan 29, 2026
halter73
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses unresolved feedback from #1191: the test class was overriding
LoggerFactoryto useLogLevel.Tracefor all tests, butDebugshould remain the default since Trace is too verbose for general test output.Changes
LoggerFactoryoverride from constructor (now uses base class default ofDebug)SendMessageAsync_Should_Log_At_Trace_LevelandReadMessagesAsync_Should_Log_Received_At_Trace_Levelto create local trace-level logger factories for their specific needsOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.