Skip to content

Conversation

@maxisbey
Copy link
Contributor

Summary

Replaces the custom conformance test scripts with the composite GitHub Action from modelcontextprotocol/conformance. This is a proof-of-concept to validate the action works in CI before tagging a release.

Depends on: modelcontextprotocol/conformance#113

Changes

  • Server job: Inlines the server startup, replaces run-server.sh's npx call with the action
  • Client job: Replaces the inline npx call with the action
  • Removes actions/setup-node steps (handled by the action)
  • Removes continue-on-error: true (Python SDK passes all tests)

Before

- uses: actions/setup-node@...
- run: npx @modelcontextprotocol/conformance@0.1.10 server --url ...

After

- uses: modelcontextprotocol/conformance@ab789d6
  with:
    mode: server
    url: http://localhost:3001/mcp

Once the conformance repo tags a release, the ref will be updated to a proper version tag.

Replace custom npx scripts with the composite action from
modelcontextprotocol/conformance. This simplifies the workflow by:

- Removing the manual actions/setup-node step (handled by the action)
- Replacing run-server.sh's npx call with the action
- Replacing the inline npx call for client tests with the action
- Removing continue-on-error (Python SDK passes all tests)

References conformance repo at commit ab789d6 (expected-failures branch)
until a tagged release is available.
@maxisbey maxisbey marked this pull request as ready for review January 21, 2026 16:28
@maxisbey maxisbey marked this pull request as draft January 21, 2026 16:30
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it should go on the root directory, but besides that, all good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants