Skip to content

Conversation

@joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Jan 29, 2026

Refs: #61579

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/single-executable

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications labels Jan 29, 2026
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this testable (e.g. passing a non-existent binary in the config?)?

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.77%. Comparing base (68d7b6f) to head (e145ec8).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sea_bin.cc 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61581      +/-   ##
==========================================
- Coverage   89.77%   89.77%   -0.01%     
==========================================
  Files         673      673              
  Lines      203820   203844      +24     
  Branches    39175    39178       +3     
==========================================
+ Hits       182987   183002      +15     
- Misses      13152    13177      +25     
+ Partials     7681     7665      -16     
Files with missing lines Coverage Δ
src/node_sea_bin.cc 41.72% <50.00%> (+0.12%) ⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants