Skip to content

sea: print error information when fs operations fail #61581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joyeecheung wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −4
Open

sea: print error information when fs operations fail #61581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/node_sea_bin.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,8 +395,10 @@ ExitCode BuildSingleExecutable(const std::string& sea_config_path,
uv_fs_t req;
int r = uv_fs_stat(nullptr, &req, config.executable_path.c_str(), nullptr);
if (r != 0) {
FPrintF(
stderr, "Error: Couldn't stat executable %s\n", config.executable_path);
FPrintF(stderr,
"Error: Couldn't stat executable %s: %s\n",
config.executable_path,
uv_strerror(r));
uv_fs_req_cleanup(&req);
return ExitCode::kGenericUserError;
}
Expand All @@ -406,8 +408,10 @@ ExitCode BuildSingleExecutable(const std::string& sea_config_path,
std::string exe;
r = ReadFileSync(&exe, config.executable_path.c_str());
if (r != 0) {
FPrintF(
stderr, "Error: Couldn't read executable %s\n", config.executable_path);
FPrintF(stderr,
"Error: Couldn't read executable %s: %s\n",
config.executable_path,
uv_strerror(r));
return ExitCode::kGenericUserError;
}

Expand Down
Loading