Open
Conversation
Contributor
Author
|
i totally forget the frontend, will do the changes this week. |
Contributor
Author
|
turned out that the cli readme is outdated and the option parser works already the same on all platforms. i still think it makes sense to replace it with another more intiutive option parser. |
Member
|
I think this is a good change. But we have to change the way it handle parameters right? like -o"../../.." needs a space between -o and value ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i replaced the option parser with cxxopts, it should have the interface now on all platforms.
the version flag is still missing, but in case you wanna merge this, i think it is important to first merge my other pr #242 and tag it.
then this would be already a new major release.
i only tested on osx.
let me know what you think, anything i should improve?